Enable type-checking for examples#430
Open
thierry-martinez wants to merge 8 commits intoTeamGraphix:masterfrom
Open
Enable type-checking for examples#430thierry-martinez wants to merge 8 commits intoTeamGraphix:masterfrom
thierry-martinez wants to merge 8 commits intoTeamGraphix:masterfrom
Conversation
This commit adds type annotations in all example modules, and refines the type of `PatternSimulator` constructor, so that the type parameter for states is automatically inferred from the `backend` argument. It enables full type-checking with mypy and pyright while preserving existing functionality across the entire code base. No files are ignored by the typers anymore. **Related issue:** This commit continues the work started in TeamGraphix#302, TeamGraphix#308, TeamGraphix#312, TeamGraphix#347, and TeamGraphix#414.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emlynsg
approved these changes
Feb 12, 2026
Contributor
emlynsg
left a comment
emlynsg
left a comment
There was a problem hiding this comment.
Looks good to me. Do we mind that there are still lots of Pyright warnings?
Collaborator
Author
|
Actually, they were only three warnings:
There are 395 informations: we can see if there is something we can do with them at some point, but I consider it is out of the scope of this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds type annotations in all example modules, and refines the type of
PatternSimulatorconstructor, so that the type parameter for states is automatically inferred from thebackendargument.It enables full type-checking with mypy and pyright while preserving existing functionality across the entire code base. No files are ignored by the typers anymore.
Related issue:
This commit continues the work started in #302, #308, #312, #347, and #414.